Inserting string value using substring not returning intended output

Question

This simple program I am making, solution, isn't returning the intended output.

If the string includes the phrase camelCasing the expected output should be camel Casing. If the string includes any other words like camelCasingCarrier the output should be camel Casing Carrier.

If the string includes any other phrase, it should just return the string.

function solution(string) {
  let newString = null;
  let stringToAdd = ' '
  if (string.includes('camelCasing')) {
    for (let i = 0; i < string.length; i++) {
      let letter = string[i];
      if (letter == letter.toUpperCase()) {
        newString = string.substring(0, letter) + stringToAdd + string.substring(letter);
      }
    }
    return newString;
  } else {
    return string;
  }
}

My current output is camelCasingCarrier with a space at the beginning rather than the expected output. What is my issue and how should I fix this? Thanks again :)

Each time through the loop you overwrite the changes to newString that you made on the previous iteration. — Barmar
– Barmar, Commented Feb 16, 2022 at 20:06
You need to accumulate characters in newString, not overwrite it completely. — Barmar
– Barmar, Commented Feb 16, 2022 at 20:07
I see I see, should I then accumulate characters into an array and then join them together into a string? @Barmar — baphomet
– baphomet, Commented Feb 16, 2022 at 20:11
string.substring takes numeric arguments, but letter is a letter. Maybe you meant to use i? — James
– James, Commented Feb 16, 2022 at 20:19
You can accumulate into a string. Initialize newString = '' then use newString += to add to it. — Barmar
– Barmar, Commented Feb 16, 2022 at 20:20

André · Accepted Answer · 2022-11-22 15:21:03Z

1

The substring method string.substring(start, end) takes up to two arguments, integer numbers that must be the index range of the string, to generate a substring from. In your case you are using a letter (letter) as an argument and this won't work. If you use the index i instead of letter it would work, but only for a single replacement and not for "camelCasingCarrier" for example.

As you already mentioned, the best solution is to avoid using the substring method and simply add a space before the capital letters as you parse over the string:

function solution(string) {
  let newString = '';
  if (string.includes('camelCasing')) {
    for (let i = 0; i < string.length; i++) {
      let letter = string[i];
      if (letter == letter.toUpperCase()) {
        newString += ' ' + letter;
      } else {
        newString += letter;
      }
    }
    return newString;
  } else {
    return string;
  }
}

edited Nov 22, 2022 at 15:21

answered Nov 22, 2022 at 13:56

André

2,06810 gold badges20 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Wyck Over a year ago

Your answer would be better if you called attention to what the original problem was and how your solution fixes the problem.

André Over a year ago

Thank you, I added more info.

Collectives™ on Stack Overflow

Inserting string value using substring not returning intended output

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related