jQuery - Syntax Error in a Conditional

Question

$(".editAd").change({
    if ($(this).val() == 1)
        {
            $("#submitBtn").val("Next Step");
        }
        else
        {
            $("#submitBtn").val("Submit Changes");
        }
    });

There is a syntax error on the second line of this code. Missing : after property ID. I swore this was the proper use of val() in a conditional, but I suppose I could be wrong...

I know this is a pretty simple fix, but I can't find any resources off of a few minutes of research, and I was hoping the users of SO could help me out. :)

Thank you!

EDIT: There's always a silly error that developers make that stumps them for a period of time... Always review the ENTIRETY of your code for errors because the developer tools may not actually pick up the proper line of the error, as in this case.

try assigning the $(this).val() to a variable before the if and compare that. see what happens. — Eonasdan
– Eonasdan, Commented Sep 21, 2011 at 18:58

aziz punjani · Accepted Answer · 2011-09-21 18:59:35Z

4

You forgot to include function(){}

$(".editAd").change(function(){
    if ($(this).val() == 1)
        {
            $("#submitBtn").val() = "Next Step";
            console.log($("#submitBtn").val());
        }
        else
        {
            (element.attr("name") == "submitBtn").val() = "Submit Changes"; // no idea  what this is but it doesn't look like it will work 
        }
    });

answered Sep 21, 2011 at 18:59

aziz punjani

25.8k9 gold badges49 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Eonasdan Over a year ago

I knew something didn't look right! I can't believe I didn't see that, nice catch!

aziz punjani Over a year ago

There's many other things wrong with this, but i figured you would get to those sooner or later :-P

TaylorPLM Over a year ago

Yeah, the else case was the first version of my code, taken from another plugin that used the same kind of syntax. It will be changed to look like the if case in the future.

aziz punjani Over a year ago

Taylor, please mark as answered if this answer helped you. This would allow me to gain some points. Thanks!

TaylorPLM Over a year ago

Aha, my apologies. I went out to lunch. :P

hvgotcodes · Accepted Answer · 2011-09-21 19:00:47Z

1

val() is a function execution.

to set a value do something like

$('selector').val('set me');

not

$('selector').val() = 'set me';

start there. Other things might clear up.

answered Sep 21, 2011 at 19:00

hvgotcodes

121k33 gold badges209 silver badges237 bronze badges

5 Comments

TaylorPLM Over a year ago

I'm not attempting to set a value... I'm attempting to perform an equivalency test on the value of the selector. Hence the double equals.

hvgotcodes Over a year ago

then what's this $("#submitBtn").val() = "Next Step";

hvgotcodes Over a year ago

and this (element.attr("name") == "submitBtn").val() = "Submit Changes";

TaylorPLM Over a year ago

I apologize. In my version of the code these changes (which I used as outlines for the proper code, from syntax written in other plugins that were not written by me) had already been fixed, and I had not referred to the code that I posted in the question.

Dennis Over a year ago

@TaylorPLM It would be helpful to anyone with similar problem in the future if you could edit the question with the val calls fixed. That way they can quickly see that omitting function() is the real problem.

James Allardice · Accepted Answer · 2011-09-21 19:04:07Z

There are numerous problems with your code. Firstly, the cause of the error you are talking about, is the missing function keyword. That's required as the change method takes a function as an argument.

Next, you're assigning a value to the val method, which is incorrect ($("#submitBtn").val() = "Next Step";). You need to pass the string in as an argument.

Third, your else block is very confusing. I'm not sure what you were trying to do there, but it will evaluate to something like true.val() = "Submit Changes"; which is completely wrong. It's another assignment to a function, and you're trying to call that function on a boolean value, not a jQuery object.

So, based on all that, this is what I think you were trying to do:

$(".editAd").change(function(){
    if ($(this).val() == 1) {
        $("#submitBtn").val("Next Step");
        console.log($("#submitBtn").val());
    }
    else {
        if($(element).attr("name") == "submitBtn") {
            $(element).val("Submit Changes");
        }
    }
});

Dennis · Accepted Answer · 2011-09-21 19:13:23Z

0

Missing : after property ID This is caused by the lack of a function () identifier before the conditional. Because it was bracketed {} the javascript parser thought you were passing an object literal with if as a property identifier. It was looking for a colon after it to identify the value of the property.

Not sure what you are trying to do on this line:

(element.attr("name") == "submitBtn").val() = "Submit Changes";

But it looks like you are trying to call val on a boolean value, which is not valid. You are also assigning a string to the output of val() which won't work.

To assign a value to an element, jQuery's val takes one parameter:

element.val("Submit Changes");

edited Sep 21, 2011 at 19:13

answered Sep 21, 2011 at 19:03

Dennis

32.7k12 gold badges66 silver badges79 bronze badges

Collectives™ on Stack Overflow

jQuery - Syntax Error in a Conditional

4 Answers 4

5 Comments

5 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

5 Comments

5 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related