-1

today i created a hello world app. It's not a simple hello world app. It uses classes, custom exceptions, threads, generics, custom annotation and more. The problem here is that the AnnotationApplyer class which checks if the annotations is well applyed does not do anything.

I tried to create an annotation that says that the class is a user-defined exception (extends java.lang.Exception class). This does not work, do i made a mistake at checking or something else?

import java.lang.annotation.*;

@UserException // wrong placed annotation for testing
@UserDefined(user = "iasonas")
public abstract class Main {

    public static void main(String[] args) {
        // check annotations
        AnnotationApplyer.check();

        // start the program
        new Greeter().greet();
    }
    
    @UserDefined(user = "iasonas")
    private static class Greeter {
        private final String MSG = "Hello, World!";
        private Printer ms = new MessageService<String>(MSG);
        
        public Greeter () {
        }
        
        public void greet () {
            try {
                ms.print();
            } catch (InvalidMessageException e) {
                System.out.println("Cannot greet. "+e.toString());
            }
        }
    };
};

@UserException // wrong placed annotation for testing
@UserDefined(user = "iasonas")
class AnnotationApplyer {
    public static void check () {
        checkUserException(Main.class, AnnotationApplyer.class, MessageService.class, UserDefined.class);
        checkUserException(UserException.class, Printer.class, InvalidMessageException.class);
        
    }

    public static void checkUserException (Class<?>... classes) {
        for (Class<?> clazz : classes) {
            if (!clazz.isAnnotationPresent(UserException.class)) {
                continue;
            }

            if (!Exception.class.isAssignableFrom(clazz)) {
                System.out.println("Error: "+clazz.getName()+" does not extend java.lang.Exception");
            } else {
                System.out.println("Class "+clazz.getName()+" extends java.lang.Exception!");
            }
        }
    }
}

@Target(ElementType.TYPE)
@interface UserException {

}

@Retention(RetentionPolicy.RUNTIME)
@Target(ElementType.TYPE)
@interface UserDefined {
    String user() default "Not specified";
}

class MessageService <T> implements Runnable, Printer {
    private T message;
    private final Thread thread = new Thread(this);
    private int printCounter;
    
    public MessageService () {   
    }
    
    public MessageService (T message) {
        this.message = message;
    }

    public T getMessage () {
        return message;
    }
    
    public void setMessage (T aMsg) {
        this.message = aMsg;
    }

    public int getTimes () {
        return printCounter;
    }
    
    @Override
    public void run () {
        System.out.println(message);
        printCounter++;
    }
    
    @Override
    public synchronized void print () throws InvalidMessageException {
        if (message==null) {
            throw new InvalidMessageException("message is null");
        }
        thread.start();
    }
};

interface Printer {
    void print() throws InvalidMessageException;
};

@UserException // well placed annotation for checking
class InvalidMessageException extends Exception {
    public InvalidMessageException (String m) {
        super(m);
        System.exit(0);
    }
}


7
  • Keep in mind that using reflection in your own code is usually a sign of poor design. Commented Jan 29 at 16:55
  • @mrmcwolf how else would you check your own code for your own annotation? Commented Jan 29 at 16:56
  • Why are you using annotations? Commented Jan 29 at 16:58
  • I'm looking at UserDefined and it's applied to a static method. That might through the code you have for a loop. Double check how you are testing for annotations and check that static methods are included in your checks. Commented Jan 29 at 16:59
  • annotations break all the rules of OOP. :) Otherwise your code won't work because you need to test real objects. The AnnotationApplyer::check method needs to accept an object instance to work with. Commented Jan 29 at 17:02

1 Answer 1

0

You are missing a

@Retention(RetentionPolicy.RUNTIME)

on your UserException annotation. The default value does not ensure that the annotation is still available at runtime.

Sign up to request clarification or add additional context in comments.

2 Comments

Thanks. I changed it and it worked. This time the bug won at hide and seek :-/
If your code checks for an annotation and it's not there despite being in the source code, the Retention is most likely the problem. Your other annotation even has it. These things happen :)

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.