How to Pass PHP String Variable To JS From an Onclick Event

Question

This might have a simple answer, however I cannot figure out the correct syntax. I have the following onclick event echoed on a php page:

$ratelink = text string...
echo '<div><span id="anything" onclick="updatePos('.$ratelink.')">Save</div>';

On my JS page, I have the function:

function updatePos(ratelink)
{
  alert(ratelink); 
}

My problem is that when $ratelink is a number, the variable will pass with no problems. However, when $ratelink is a text string, like in the above example, nothing gets passed and the alert doesn't execute.

I think the following ('.$ratelink.') needs to be in a different syntax to pass text, but I don't know the exact format.

Rylab · Accepted Answer · 2011-12-14 21:15:06Z

8

You need to enclose the string in quotes when passing to the JS function, as well as in PHP:

$ratelink = 'text string...';
echo '<div><span id="anything" onclick="updatePos(\''.$ratelink.'\')">Save</div>';

answered Dec 14, 2011 at 21:15

Rylab

1,3058 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Amir Dora. · Accepted Answer · 2022-10-13 13:11:08Z

1

try this

echo '<div><span id="anything" onclick=updatePos("'.$ratelink.'")>Save</div>';

if there is space in the $ratelink variable then it should be quoted in string....

edited Oct 13, 2022 at 13:11

Amir Dora.

2,7705 gold badges47 silver badges73 bronze badges

answered Dec 14, 2011 at 21:15

Kashif Khan

2,66516 silver badges14 bronze badges

1 Comment

Amir Dora. Over a year ago

Tried many ways but this one worked for me.

Ben D · Accepted Answer · 2011-12-14 21:18:13Z

0

Your string needs to be wrapped in quotes... so you'll need to make it

echo '<div><span id="anything" onclick="updatePos(\''.$ratelink.'\')">Save</div>';

and make sure that you escape the string as well if it might have any quotes in it

answered Dec 14, 2011 at 21:18

Ben D

14.6k3 gold badges47 silver badges59 bronze badges

Comments

Gajus · Accepted Answer · 2011-12-14 21:20:44Z

0

Neither of the answers are correct. At least not the best option. Consider using json_encode() to pass any data from PHP to JS. This ensures that data is correctly escaped.

var myObj = <?=json_encode(array('php' => 'array'))?>;

console.log(myObj);

answered Dec 14, 2011 at 21:20

Gajus

74.6k81 gold badges301 silver badges479 bronze badges

Collectives™ on Stack Overflow

How to Pass PHP String Variable To JS From an Onclick Event

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related