addObject: to array not working (array still nil)

Question

This app is a table view with a tab bar controller. I am logging the count of the array: arrayOfFavourites and even though i add an object is continues to have a nil value, my relating code, all objects shown are allocated and initialized in the code (previous or present) some are instances and some are properties:

ListViewController.m:

  -(void)tableView:(UITableView *)tableView didSelectRowAtIndexPath:(NSIndexPath *)indexPath {

NSLog(@"TOUCHED CELL!");

// Push the web view controller onto the navigation stack - this implicitly 
// creates the web view controller's view the first time through
[[self navigationController] pushViewController:webViewController animated:YES];

// Grab the selected item
entry = [[channel items] objectAtIndex:[indexPath row]];

if (!entry) {
    NSLog(@"!entry");
}

// Construct a URL with the link string of the item
NSURL *url = [NSURL URLWithString:[entry link]];

// Construct a request object with that URL
NSURLRequest *req = [NSURLRequest requestWithURL:url];

  // Load the request into the web view 
[[webViewController webView] loadRequest:req];

// Take the cell we pressed
// IMPORTANT PART
CELL = [tableView cellForRowAtIndexPath:indexPath];

[webViewController setItem:entry];

webViewController = nil;
webViewController = [[WebViewController alloc] init];
[entry release];

  }

WebViewController.m:

You shake to favorite a cell

 -(void)motionBegan:(UIEventSubtype)motion withEvent:(UIEvent *)event {

cellToPassOn = nil;

NSLog(@"Favouriting"); // YES I KNOW SPELLING

// This is pretty simple, what we do is we take the cell we touched and take its title and link 
// then put it inside an array in the Favourites class

Favourites *fav = [[Favourites alloc] init];
ListViewController *list = [[ListViewController alloc] init];
[self setCellToPassOn: [list CELL]];

if (!item) {
    NSLog(@"NILLED ITEM");

}

[[fav arrayOfFavourites] addObject:[item autorelease]];
[fav setCell: cellToPassOn];
[fav release];
[list release];
item = nil;

 }

Favourites.m:

 -(NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section
  {

arrayOfFavourites = [[NSMutableArray alloc] init];


NSLog(@"ROWS NO.");
NSLog(@"%i", [arrayOfFavourites count]);

return [arrayOfFavourites count];
}

Shanti K · Accepted Answer · 2011-12-19 12:16:39Z

2

Why are you inializing the array in tableview:numberOfRowsInSection ? This will cause the array to be reset each time table view is reloaded. This could be your issue.

answered Dec 19, 2011 at 12:16

Shanti K

2,9081 gold badge19 silver badges32 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

user971401 Over a year ago

This could be also another issue, about memory leaks.

user973985 Over a year ago

i put the allocation and initialization in the initWithStyle: method but is still doesn't work... I ANALYZED THERE ARE NO MEMORY LEAKS!

Shanti K Over a year ago

When is motionBegan:withEvent: invoked? After table reload? Move the initialization of the array to view did load, and reload the table after u add object to the array

Shanti K Over a year ago

arrayOfFavourites = [[NSMutableArray alloc] init]; Assigning an iVar in the above manner, is a clear case if memory leak.

Peter Hosey Over a year ago

@ShantiKamichetty: Only if the array is not released. The assignment alone is not evidence of a leak. (And under ARC, it will be released; an explicit release message is not necessary or valid.)

|

Ajeet Pratap Maurya · Accepted Answer · 2011-12-19 12:24:11Z

0

you are allocating your array in -(NSInteger)tableView:(UITableView *)tableView numberOfRowsInSection:(NSInteger)section

try to allocate it somewhere else.

answered Dec 19, 2011 at 12:24

Ajeet Pratap Maurya

4,2643 gold badges31 silver badges46 bronze badges

1 Comment

user973985 Over a year ago

i put the allocation and initialization in the initWithStyle: method but is still doesn't work

Roemer · Accepted Answer · 2011-12-19 12:38:37Z

0

You could allocate the arrayOfFavorites in the tableView:numberOfRowsInSectionMethod, but then you first need to check if it is nil.

if( !arrayOfFavorites )
    arrayOfFavoriges = [[NSMutableArray alloc] init];

You should release it then in the dealloc method: [arrayOfFavorites release].

answered Dec 19, 2011 at 12:38

Roemer

3,5861 gold badge18 silver badges32 bronze badges

3 Comments

user973985 Over a year ago

i put that in the initWithStyle method, i logged in the numberOfRowsInSection: if it was nil and it was!

user973985 Over a year ago

ok even weirder...... what i did was log the count in the numberOfRows.... section.... in my other class when i add the object to arrayOfFavourites i also reload the favorite class' table view. So i shook the device, so it gets logged again and the result turns to one as the count.... GOOD! I also log it when the view loads, when the view loads it gets logged as 0... WEIRD!!!!! I don't know why it goes nil when i enter its view.... do you know why???

user973985 Over a year ago

also if i try shake twice in different articles (WEBVIEWCONTROLLER, that is a website, the webView changes for each cell) the array is still one then goes nil! WEIRD AGAIN! THEN........ the app crashes...

Vincent Bernier · Accepted Answer · 2011-12-21 15:26:28Z

 -(void)motionBegan:(UIEventSubtype)motion withEvent:(UIEvent *)event {
 cellToPassOn = nil;
 NSLog(@"Favouriting"); // YES I KNOW SPELLING
 // HERE creation of a Brand NEW empty Favourites instance
 Favourites *fav = [[Favourites alloc] init];
 // HERE creation of a Brand NEW empty ListViewController instance
 ListViewController *list = [[ListViewController alloc] init];
 // HERE we hope that the ListViewController as CELL other then nil when it is Brand NEW
 [self setCellToPassOn: [list CELL]];

 if (!item) {
     NSLog(@"NILLED ITEM");
 }

 [[fav arrayOfFavourites] addObject:[item autorelease]];
 [fav setCell: cellToPassOn];
 [fav release];
 // HERE the fav instance get deallocated and don't exist anymore
 [list release];
 // HERE the list instance get deallocated and don't exist anymore
 item = nil;
 }

In this code list and fav exist only in the body of this method, attempt to get to the value they have hold done to will failed, because list and fav doesn't exist outside that method.

Collectives™ on Stack Overflow

addObject: to array not working (array still nil)

4 Answers 4

7 Comments

1 Comment

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

7 Comments

1 Comment

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related