PHP if statement with checkbox error

Question

Sorry for the dumb question, though I'm a little new to PHP. I've tried a lot of other ways to do this, but simply couldn't get this to work... Actually I want it to make it that I can have different functions attached to each checkbox that when a user selects a checkbox or another, and clicks the submit button, it triggers the specific functions. But I cannot get the checkboxes to work. It either works with only one selected, or if I check the 1st one then the 4th one, it outputs the 4th's code. Any other ways of doing this? Here is my attempt:

1.php

<form method="POST" action="2.php">
<input type="checkbox" name="test[]" value="test1" />test1<br />
<input type="checkbox" name="test[]" value="test2" />test2<br />
<input type="submit" name="submit" value="submit" />
</form>

2.php

$val = $_POST['test'];
if(isset($val)==true){
    for($i = 0 ; $i<count($val) ; $i++){
        if($val=='test1'){
            echo $val;
            die();
        }elseif($val=='test2'){
            echo $val;
            die();
        }else{
            echo "fail";
            die();
        }
    }
}else{
    return false;
}

Thank you.

Could you reformat your code with indentation? Really helps with readability.. Thx — calebds
– calebds, Commented Jan 12, 2012 at 19:36

Mike Purcell · Accepted Answer · 2012-01-12 19:40:55Z

1

Try:

$vals = $_POST['test'];
$valsCount = count($vals);

if ($valsCount > 0) {

    foreach ($vals as $val) {

        switch ($val) {

            case 'test1':
                echo $val;
                break;

            case 'test2':
                echo $val;
                break;

            default:
                echo 'Fail';
                break;
        }
    }
}

answered Jan 12, 2012 at 19:40

Mike Purcell

20k10 gold badges54 silver badges94 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Death.System Over a year ago

Oh thanks! I never thought of using the "case" functions before.

keithhatfield · Accepted Answer · 2012-01-12 19:53:18Z

As another option, if you're looking to call functions based on the value of the checkbox, you could do something like this ...

I've compressed it all into one file for simplicity, but this is the general idea ...

<form method="post" action="<?php echo $_SREVER['PHP_SELF']; ?>">
    <input type="checkbox" name="boxes[]" value="box1">Box 1</input><br />
    <input type="checkbox" name="boxes[]" value="box2">Box 2</input><br />
    <input type="checkbox" name="boxes[]" value="box3">Box 3</input><br />
    <input type="checkbox" name="boxes[]" value="box4">Box 4</input><br />
    <input type="checkbox" name="boxes[]" value="box5">Box 5</input><br />
    <input type="submit" value="Go!" />
</form>
<?php

    class boxProcessor
    {
        public function box1()
        {
            echo "<p>You've found box 1.</p>";
        }

        public function box2()
        {
            echo "<p>You've found box 2.</p>";
        }

        public function box3()
        {
            echo "<p>You've found box 3.</p>";
        }

        public function box4()
        {
            echo "<p>You've found box 4.</p>";
        }

        public function box5()
        {
            echo "<p>You've found box 5.</p>";
        }

    }

    if($_SERVER['REQUEST_METHOD'] == 'POST'){
        $boxes = $_POST['boxes'];

        if(empty($boxes)){
            echo "<p>Nothing to do ...</p>";
        } else {
            $proc = new boxProcessor();

            foreach($boxes as $box){
                $proc->$box();
            }
        }
    }
?>

Francis Lewis · Accepted Answer · 2012-01-12 20:10:58Z

1

You're pretty close with your code as is, you just have to take into account array indexes.

for ($i = 0, $length = count($val); $i < $length; $i++)
{
    // add [$i] to $val to access an index of $val
    if ($val[$i] == 'test1')

edited Jan 12, 2012 at 20:10

answered Jan 12, 2012 at 19:40

Francis Lewis

8,9889 gold badges58 silver badges68 bronze badges

4 Comments

Death.System Over a year ago

What if I'm echoing checkboxes within foreach to output the number of values in the array? Will this result in similar conditions? Because in this one, I only have one elseif.

keithhatfield Over a year ago

Your print_r statement is false. Value is a valid attribute for a checkbox. The posted array will only include values for checked boxes and will not have empty 'placeholders' for unchecked elements.

Francis Lewis Over a year ago

@Death.System, sorry, my first example was correct. Forgot what I said about value not being valid. I just changed the example back to the way it was, so once again, you were very close with your original code.

Death.System Over a year ago

I'm getting a problem when selecting both test1 and test2. This had occurred a lot, basically, I changed the code from echo $val; to echo 'test1'; and echo 'test2'; But output is "test1" instead of test1 and test2.

logiblocs · Accepted Answer · 2012-01-12 19:40:56Z

0

Try changing the names from test1[] to test1 in 1.php and also check a typo on line 7- 2.php.

Hope this helps.

answered Jan 12, 2012 at 19:40

logiblocs

585 bronze badges

Comments

paulsm4 · Accepted Answer · 2012-01-12 19:45:06Z

0

There are a couple of issues that probably don't have anything to do with the real problem:

1) You talk about "1st" and "4th" checkboxes ... but your code only shows two checkboxes

2) Your example misspells "tes2" (so PHP won't/can't find it)

3) You should probably get rid of all the "die()" clauses

SUGGESTION:

Check out this link:

http://www.html-form-guide.com/php-form/php-form-checkbox.html

answered Jan 12, 2012 at 19:45

paulsm4

123k23 gold badges175 silver badges245 bronze badges

1 Comment

Death.System Over a year ago

Well my original code from before I had more than two checkboxes while looping through an array. I see the typo, but when fixing it, still occurs, also I've checked that tried it, couldn't get it to work. It was outputting the same thing two times. For the multiple checkboxes.

Collectives™ on Stack Overflow

PHP if statement with checkbox error

5 Answers 5

1 Comment

Comments

4 Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

Comments

4 Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related