PHP header returning with spaces when using variables?

Question

I have asked a question earlier but I think I missed the point so I'm gonna post it again.

I'm using the header Content-Disposition.

The code I used to do so was like this:

header("Content-Disposition: attachment; filename='{$name}'");

It returns this:

Content-Disposition attachment; filename=' Bassnectar - Bass Head Official.mp3 '

Note the spaces before and after the quotes. This is a problem because it changes the extension from ".mp3" to ".mp3 " which is recognized as a different file. There has to be some way to fix this. I've changed everything, I've googled everything. I don't know what is left to do?

Have you tried using trim() on $name?

j08691
– j08691

2012-02-06 04:02:22 +00:00
Commented Feb 6, 2012 at 4:02 — j08691
– j08691, Commented Feb 6, 2012 at 4:02

Jonathan · Accepted Answer · 2012-02-06 05:06:20Z

1

You should url encode and trim extra whitespace before placing in the header.

$name = rawurlencode(trim($name));
header("Content-Disposition: attachment; filename='{$name}'");

Final Solution

$name = $extract['original_name'];
$name2 = urlencode(trim($name));
$name3 = str_replace("+", " ", $name2);
$quote = '"';
header("Content-Disposition: attachment; filename=$quote{$name3}$quote");

I am pretty sure you could clean this up:

$name = $extract['original_name'];
$name = urlencode(trim($name));
$name = str_replace("+", " ", $name);
header("Content-Disposition: attachment; filename=\"{$name}\"");

And, if the urlencode does not seem to make a difference, I am pretty certain you can just do this:

$name = $extract['original_name'];
$name = trim($name);

header("Content-Disposition: attachment; filename=\"{$name}\"");

edited Feb 6, 2012 at 5:06

answered Feb 6, 2012 at 4:05

Jonathan

5,5574 gold badges40 silver badges54 bronze badges

Sign up to request clarification or add additional context in comments.

14 Comments

Jonathan Over a year ago

@RosengustaGarrett Sorry about that, wasn't thinking! I fixed the answer. Please try it and let me know if it solved the problem.

Jonathan Over a year ago

@RosengustaGarrett Hold up! The browser should automatically decode that correctly therefore accessing the correct file. If it does not work, then remove the urlencode() call and leave just trim()

Jonathan Over a year ago

@RosengustaGarrett Good song, btw!

Jonathan Over a year ago

@RosengustaGarrett You should not have to do the str_replace.

Jonathan Over a year ago

@RosengustaGarrett Updated the answer, please try rawurlencode instead of urlencode

|

ionFish · Accepted Answer · 2012-02-06 04:05:40Z

0

Try these:

<?php
$str = preg_replace('/\s\s+/', ' ', $str);
?>

or

<?php
$string = trim(ereg_replace(' +', ' ', $string));
?>

or

<?php
$name=preg_replace('/\s+/','',$name);
?>

This last one works probably the best for you.

Those will remove the spaces from your string, just make sure there's a corresponding file to match,

answered Feb 6, 2012 at 4:05

ionFish

1,0241 gold badge8 silver badges20 bronze badges

7 Comments

Garrett R Over a year ago

$name=preg_replace('/\s+/','',$name); Returned: Bassnectar-BassHeadOfficial.mp3 (I used a song as a test) That works good except it removed every space in the title. I could do the name thing str_replace(" ", "", $name) $string = trim(ereg_replace(' +', ' ', $string)); Returned: Bassnectar $str = preg_replace('/\s\s+/', ' ', $str); Returned: Bassnectar

Tadeck Over a year ago

Why remove all whitespaces? The problem was only the space at the beginning, I think.

ionFish Over a year ago

@RosengustaGarrett - You only want the space removed from the extension... Can you make two variables called $name and $ext then use the space-remover for the $ext and merge it with $name like '$name' . '$ext'

Garrett R Over a year ago

@Tadeck I'm not trying to remove all white spaces just the space from the very front and very back.

ionFish Over a year ago

@RosengustaGarrett - Very glad to hear.

|

Collectives™ on Stack Overflow

PHP header returning with spaces when using variables?

2 Answers 2

14 Comments

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

14 Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related