PHP/Codeigniter - For Loop [Undefined offset]

Question

for($i=0;$i<count($status);$i++)
{
    $conf = array(
        'source_image' => $status[$i]['full_path'],
        'new_image' => $this->upload_path . '/thumbs',
        'maintain_ratio' => true,
        'width' => 200,
        'height' => 200
    );

    $this->load->library('image_lib', $conf);
    $this->image_lib->resize();

    $this->image_lib->clear(); // complete reset    
    $this->image_lib->initialize($conf); // complete reset
}

            .

always keep missing the last thumbnail creation cycle. when trying for($i=0;$i<=count($status);$i++). i get this notice Undefined offset

when i keep the condition as less than $status i miss an image, when i keep the condition as less than equal to the script creates a blank array. — user1295342
– user1295342, Commented Mar 29, 2012 at 13:44
Are you sure that the full_path index exists in the last item of the $status? — erdeszt
– erdeszt, Commented Mar 29, 2012 at 13:47
Pretty please (with sugar on top) don't use count() in a loop condition. Cache the array length in a variable before the loop. — DaveRandom
– DaveRandom, Commented Mar 29, 2012 at 13:49

DaveRandom · Accepted Answer · 2012-03-29 13:52:06Z

2

By using a for loop you are assuming that the keys of the array are contiguous, which they may not be. You are also assuming that every second level array has a full_path key, which it may not. Use foreach instead, and do an isset() check on the full_path key:

foreach ($status as $item)
{

    if (!isset($item['full_path'])) continue;

    $conf = array(
        'source_image' => $item['full_path'],
        'new_image' => $this->upload_path . '/thumbs',
        'maintain_ratio' => true,
        'width' => 200,
        'height' => 200
    );

    $this->load->library('image_lib', $conf);
    $this->image_lib->resize();

    $this->image_lib->clear(); // complete reset    
    $this->image_lib->initialize($conf); // complete reset
}

answered Mar 29, 2012 at 13:52

DaveRandom

88.8k11 gold badges159 silver badges174 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Taha Paksu · Accepted Answer · 2012-03-29 13:51:20Z

0

try this:

$this->load->library('image_lib');
$stat = array_values($status);
for($i=0;$i<count($stat);$i++)
{
$conf = array(
    'source_image' => $stat[$i]['full_path'],
    'new_image' => $this->upload_path . '/thumbs',
    'maintain_ratio' => true,
    'width' => 200,
    'height' => 200
);

$this->image_lib->initialize($conf); // complete reset
$this->image_lib->resize();

}

answered Mar 29, 2012 at 13:51

Taha Paksu

15.6k2 gold badges50 silver badges83 bronze badges

Collectives™ on Stack Overflow

PHP/Codeigniter - For Loop [Undefined offset]

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related