How to insert data from database using oops php concepts?

Question

I try to insert one person detail, it's inserted successfully. If i check in DB "same data insert 3 times". Why the data insert 3 times?

I had this data in the Database.

id      name       dob             gen
1       James     12-03-1977        M
2       James     12-03-1977        M
3       James     12-03-1977        M

PHP class

class Detail
{
function savePerson_detail($vars){
    foreach($vars as $key => $value){
       if(is_numeric($key) && $value >0){
         $qry = sprintf("INSERT INTO cca_student_list(per_name, per_dob, per_gen) VALUES('%s', '%s', '%s')",
        mysql_real_escape_string($vars['name']),
        mysql_real_escape_string($vars['dob']),
        mysql_real_escape_string($vars['gen']));
        mysql_query($qry) or die(mysql_error());
         if($qry)
    {
    print 'Successfully Insert your details';
    }
   }
}

Html Page

<?php
$detail = new Detail();
if(isset($_POST['btnSaveDetail'])){
   $detail->savePerson_detail($_POST);
}?>

your question title is not quite related to your question content... — Raptor
– Raptor, Commented Aug 11, 2011 at 9:09

hakre · Accepted Answer · 2011-08-11 09:09:23Z

1

You actually run the query three times, that is why you insert the data three times. Just run the query one time and you should be fine.

To do this you need to change your code: First sanitize the input data in full, then run the query. You are currently picking each element of $vars (which has three elements) and then you run the query each time.

Do one step after the other:

function savePerson_detail($vars)
{
    // validate function input
    foreach($vars as $key => $value)
    {
       if(!is_numeric($key) || !$value >0)
         return;
    }

    // build sql query
    $qry = sprintf(
        "INSERT INTO cca_student_list(per_name, per_dob, per_gen) VALUES('%s', '%s', '%s')",
        mysql_real_escape_string($vars['name']),
        mysql_real_escape_string($vars['dob']),
        mysql_real_escape_string($vars['gen'])
    );

    // run sql query
    $result = mysql_query($qry) or die(mysql_error());

    // check query result
    if($result)
    {
        print 'Successfully Insert your details';
    }
}

answered Aug 11, 2011 at 9:09

hakre

200k55 gold badges454 silver badges865 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

pleasedontbelong Over a year ago

Just a little suggestion: this function could return true or false instead of using print. Or maybe throw an Exception that the main php file should catch

hakre Over a year ago

Yeah and it coulb be using PDO, dependency injection, real validation, a builder for the SQL string, parameterization of the data configuration in use etc. There is a lot which comes to mind that is bad with it, but for me was important to first step ahead from the original code to deal with the logical flaw it had.

ace · Accepted Answer · 2011-08-11 09:13:22Z

0

Because you used

foreach($vars as $key => $value){

When $vars or $_POST which was passed to it looks like this.

$_POST['name'] = 'James';
$_POST['dob'] = '12-03-1977';
$_POST['gen'] = 'M';

So it went through each of your $_POST items 3 times. I think you can remove the validation and do it like this.

function savePerson_detail($vars){
  $qry = sprintf("INSERT INTO cca_student_list(per_name, per_dob, per_gen) VALUES('%s', '%s', '%s')", mysql_real_escape_string($vars['name']), mysql_real_escape_string($vars['dob']), mysql_real_escape_string($vars['gen']));
  mysql_query($qry) or die(mysql_error());
  if($qry)
    { print 'Successfully Insert your details'; }
}

answered Aug 11, 2011 at 9:13

ace

7,6513 gold badges25 silver badges28 bronze badges

Comments

pb149 · Accepted Answer · 2011-08-11 09:14:53Z

0

Unless I'm missing something, is this what you're trying to do?

class Detail
{
function savePerson_detail($vars) {
     foreach($vars as $key => $value) {
          $vars[$key] = mysql_real_escape_string($value);
     }

     if($qry)
     {
       print 'Successfully Insert your details';
     }

   $qry = sprintf("INSERT INTO cca_student_list(per_name, per_dob, per_gen) VALUES('%s', '%s', '%s')";
   mysql_query($qry) or die(mysql_error());
}

answered Aug 11, 2011 at 9:14

pb149

2,2981 gold badge22 silver badges30 bronze badges

Collectives™ on Stack Overflow

How to insert data from database using oops php concepts?

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related