Optimize Javascript Method to fill or empty an array

Question

I'm wondering if there is a better way to add/remove checkbox values to an array. Sadly i can't use ECMAScript 5 indexOf() as i need to support IE8/7.

Here is a working jsfiddle example: http://jsfiddle.net/puyQr/

What this Method does is:

/**
 * If a user clicks onto the checkbox, the value of the value attribute is
 * only added to the array when the value not yet exists. However, if
 * the value already exists, the value is removed.
 */

var values = [];
jQuery(':checkbox').on('click', function(){     
    var index = jQuery.inArray(this.value, values);
    if(index === -1) {
        values.push(this.value);
    } else {
        values.splice(index, 1);
    }
});

You could keep an object as a map and add/remove the checkbox names (or values I guess). It'd be faster, though unless you've got hundreds of checkboxes it'd make no real difference. — Pointy
– Pointy, Commented Jan 11, 2013 at 14:44

gearsdigital · Accepted Answer · 2013-01-11 14:56:23Z

2

Just another way to get values from checkboxes:

var values = jQuery(':checkbox:checked').map(function(){
    return $(this).val();
}).get();

demo

edited Jan 11, 2013 at 14:56

gearsdigital

14.2k6 gold badges46 silver badges73 bronze badges

answered Jan 11, 2013 at 14:49

Engineer

48.9k12 gold badges90 silver badges93 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Paul S. · Accepted Answer · 2013-01-11 14:58:57Z

2

Yes, use an object literal.

var values = {};
jQuery(':checkbox').on('click', function () {     
    if (this.value in values && values[this.value] === 1) {
        values[this.value] = 0;
    } else {
        values[this.value] = 1;
    }
});

see here.

If you want it as an Array later, converting it is a simple matter, using for..in and checking the value is 1 before keeping the key.

edited Jan 11, 2013 at 14:58

answered Jan 11, 2013 at 14:50

Paul S.

66.6k9 gold badges129 silver badges143 bronze badges

Collectives™ on Stack Overflow

Optimize Javascript Method to fill or empty an array

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related