PHP Class Variable problem

Question

I have this class:

class TestClass
{
    var $testvar;
    public function __construct()
    {
        $this->$testvar = "Hullo";
        echo($this->$testvar);
    }
}

And this method for accessing:

function getCurrent()
{
    $gen = new TestClass();
}

I get the following error:

Notice: Undefined variable: testvar in /Users/myuser/Sites/codebase/functions.php on line 28
Fatal error: Cannot access empty property in /Users/myuser/Sites/codebase/functions.php on line 28

What's going on?

jheddings · Accepted Answer · 2009-11-02 21:06:08Z

6

You don't need to use the variable reference when you access the variable:

$this->testvar;

By using $this->$testvar, your PHP script will first look for $testvar, then find a variable in your class by that name. i.e.

$testvar = 'myvar';
$this->$testvar == $this->myvar;

answered Nov 2, 2009 at 21:06

jheddings

27.7k10 gold badges58 silver badges68 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kevin Peno · Accepted Answer · 2009-11-02 21:05:18Z

3

Remove the $ before testvar in your call to it:

$this->testvar = "Hullo";
echo($this->testvar);

answered Nov 2, 2009 at 21:05

Kevin Peno

9,2261 gold badge36 silver badges56 bronze badges

Comments

Alex · Accepted Answer · 2009-11-02 21:44:06Z

2

Since var is deprecated I'd suggest to declare it as one of private, public or protected.

class TestClass
{
    protected $testvar;
    public function __construct()
    {
        $this->testvar = "Hullo";
        echo $this->testvar;
    }
}

answered Nov 2, 2009 at 21:44

Alex

12.5k7 gold badges47 silver badges52 bronze badges

Collectives™ on Stack Overflow

PHP Class Variable problem

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related