javascript string.replace not working

Question

I'm trying to dynamically replace a sub string in a parent string. I've tried string.replace('old','new') to no avail.

Here's the snippet giving me trouble.

newbuffer.replace( matches[i], p.shortcodes[x].vala );
console.log( "Replace " + matches[i] + " with " + p.shortcodes[x].vala );

Result is

"Replace [hello] with <span class="strong"><p>Awaiting ajax request...</p></span">"

Am I missing something here? Does .replace take "plain text" or will I need to do some regex?

Replace takes both plain text and regex. What is in newbuffer variable? — demkalkov
– demkalkov, Commented Aug 14, 2014 at 8:33

T.J. Crowder · Accepted Answer · 2014-08-14 08:33:23Z

3

replace returns a new string with the replacement, it doesn't change the string you call it on.

newbuffer = newbuffer.replace( matches[i], p.shortcodes[x].vala );

Does .replace take "plain text" or will I need to do some regex?

You can call replace either with a string as the "search" argument, or with a regex. If you give it a string, it will replace the first occurrence of that string. If you give it a regex, it will replace the first match, or all matches, depending on whether you include the g ("global") flag on the regex.

answered Aug 14, 2014 at 8:33

T.J. Crowder

1.1m201 gold badges2k silver badges2k bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

javascript string.replace not working

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related