Associative Array + Foreach statement -- undefined variable

Question

I'm really struggling with making this work, I have looked at guides but I can't seem to see the difference between mine and theirs, other than how the array is laid out.

<?php
$country = array('England' => "London", 'Scotland' => "Edinburgh", 'France' => "Paris");

foreach ($capitals as $country=>$capital) {
echo "The capital of $country is $capital";
}

?>

All I want it to do is say the country and its capital.

error code --

Notice: Undefined variable: capitals in C:\xampp\htdocs\foreach.php on line 4

Warning: Invalid argument supplied for foreach() in C:\xampp\htdocs\foreach.php on line 4

Thanks in advance.

Well, where did you define $capitals? I don't see it anywhere. I guess you want to use $capitals = array(...); instead of $country = array(...);. — Felix Kling
– Felix Kling, Commented Dec 17, 2014 at 16:52
You could at least include the example shown in the guide for comparison. Saying "I've been looking at guides" doesn't tell us which guide. — Pokechu22
– Pokechu22, Commented Dec 17, 2014 at 17:01
Which part of Undefined variable: capitals don't you understand? (that's a serious question, I'm not being condescending, just don't know how to phrase it better). It gives a pretty clear signal what is wrong, namely that you are trying to access a variable that doesn't exist. — Felix Kling
– Felix Kling, Commented Dec 17, 2014 at 17:06

Rizier123 · Accepted Answer · 2014-12-17 16:59:47Z

5

Change your code to this:

(I change the array name from country to capitals)

<?php

    $capitals = array('England' => "London", 'Scotland' => "Edinburgh", 'France' => "Paris");

    foreach ($capitals as $country=>$capital) {
        echo "The capital of $country is $capital<br />";
    }

?>

Output:

The capital of England is London
The capital of Scotland is Edinburgh
The capital of France is Paris

edited Dec 17, 2014 at 16:59

answered Dec 17, 2014 at 16:52

Rizier123

59.8k17 gold badges106 silver badges167 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Felix Kling Over a year ago

What did you change and why?

Rizier123 Over a year ago

@FelixKling I change the array name from: country to capitals, because OP just named the array wrong.

Mo Martin Over a year ago

Thanks I knew it would be a small change that fixed it

Jay Blanchard · Accepted Answer · 2014-12-17 16:57:37Z

0

You're trying to loop through an array, $capitals, that doesn't exist. You have to loop through the array $country.

foreach ($country as $country=>$capital) {
    echo "The capital of $country is $capital";
}

answered Dec 17, 2014 at 16:57

Jay Blanchard

34.5k17 gold badges82 silver badges130 bronze badges

4 Comments

Felix Kling Over a year ago

Will there be any problems with naming the loop variable $country as well?

Jay Blanchard Over a year ago

In testing it works just fine. It isn't good style, but it works @FelixKling

Felix Kling Over a year ago

Only if you don't want to access the array after the loop: codepad.org/2KxU6ACH

Jay Blanchard Over a year ago

True @FelixKling - my answer was more about looping through something that didn't exist.

Collectives™ on Stack Overflow

Associative Array + Foreach statement -- undefined variable

2 Answers 2

3 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related