`Undefined index` error complaining about variable values in foreach iterating array

Question

I am trying to write a func to replace a large chunk of repetitive code:

$inputVals = array( $siteId, $siteName, $numHspaBbu, $numLteBbu, $extAlarmsTerminated, $cellLowPower );

    function updateVarVals( $inputVals ) { // assign values to $vars after Update button clicked      
      foreach( $inputVals as $val ) {
        if ( $_POST[ $val ] !== "" ) { // if $_POST value is not empty then assign to $var and corresponding $_SESSION value  
        $val = $_SESSION[ $val ] = $_POST[ $val ];
        } else { // re-assign $_SESSION value to $var
          $val = $_SESSION[ $val ];
        } // close IF
      } // close FOREACH
    } // close FUNC

    updateVarVals( $inputVals );

but no matter how I quote $val I keep getting:

Notice: Undefined index: <$val value> in C:\xampp\htdocs\database on line 145.

for every iteration of the loop. Why is PHP expecting variable values to be defined here?

Possible duplicate of PHP: "Notice: Undefined variable", "Notice: Undefined index", and "Notice: Undefined offset" — Masivuye Cokile
– Masivuye Cokile, Commented Mar 20, 2017 at 9:11
Cau u share the more information about the variables that are being passed in $inputVals? Are these keys being used as key in your $_POST array? — Afshan Shujat
– Afshan Shujat, Commented Mar 20, 2017 at 9:15
did you validate your inputs to see if they are set and not empty? — Masivuye Cokile
– Masivuye Cokile, Commented Mar 20, 2017 at 9:15
@Masivuye Cokile: Inputs are initially set by SQLquery to DB on Retreive event and print_r( $inputVals ); proves it. Then if user alters one of the inputs and clicks update, JS code detects on(change) and sends change via ajax.php file, which I am now trying to use to update php vars accordingly: if ( empty( $_POST[ $val ] ) { then re-assign $_SESSION[ $val ] to $val, otherwise assign changed input value to $var & $_SESSION[ $val ]. And after Update event print_r( $inputVals ); again proves the changed values are assigned accordingly. — commnux
– commnux, Commented Mar 20, 2017 at 9:29

Asperitas · Accepted Answer · 2017-03-20 09:32:04Z

1

Well if Your $_POST[$val] does not exist, it'll throw that error.

If you replace if ( $_POST[ $val ] !== "" ) { with if ( empty($_POST[ $val ]) ) {, which checks if a variable is set and not empty, then you shouldn't be getting that error anymore.

edited Mar 20, 2017 at 9:32

answered Mar 20, 2017 at 9:13

Asperitas

3546 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

commnux Over a year ago

no change specifying empty() instead. But good for you to point that out as I have been immersing myself in JS tuts lately and I find I am mixing conventions up lots. Cheers.

Collectives™ on Stack Overflow

`Undefined index` error complaining about variable values in foreach iterating array

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related