a javascript fuction doesn't execute when i echo that in php code

Question

I want to echo the following html code on my page. But the onclick event doesn't work when I do this. the $senduser has the correct value

$table1="<div id='sendmsg' class='row'>
<div class='col-lg-6'>
<textarea id='msg' cols='40' placeholder='Write your message here...'></textarea>
</div><div class='col-lg-2' >
<button type='button' onClick='sendmsg(".$senduser.")' class='btn btn-success' value='send' id='msgbtn'>Send to</button></div></div>";

echo $table1;

my javascript function:

function sendmsg(senduser){
  alert(senduser);
  .
  .
  .
}

Alert doesn't show anything.

Corrected some syntax, added block ticks around what was needed, and removed unnecessary "please" and "thank" from the question :). — Patrice
– Patrice, Commented Mar 5, 2015 at 17:55

jeroen · Accepted Answer · 2015-03-05 11:58:28Z

1

$senduser is probably a string and as you don't quote it, it is interpreted as a (undefined...) variable in javascript.

You need to quote it:

...
<button type='button' onClick='sendmsg(\"".$senduser."\")' class='btn btn-success' ...
 //                                    ^^ here        ^^ and here

answered Mar 5, 2015 at 11:58

jeroen

91.8k22 gold badges117 silver badges132 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Jamie Hutber · Accepted Answer · 2015-03-05 11:59:06Z

0

Make sure you're wrapped the javaScript in a script tag

<script>
   function sendmsg(senduser){
          alert(senduser);
          .
          .
          .
    }
</script>

answered Mar 5, 2015 at 11:59

Jamie Hutber

28.2k54 gold badges194 silver badges314 bronze badges

Comments

I'm Geeker · Accepted Answer · 2015-03-05 12:01:17Z

0

Try this

<?php 
$senduser = '1';
$table1="<div id='sendmsg' class='row'>
<div class='col-lg-6'>
<textarea id='msg' cols='40' placeholder='Write your message here...'></textarea>
</div><div class='col-lg-2' >
<button type='button' onClick='sendmsg(".$senduser.")' class='btn btn-success' value='send' id='msgbtn'>Send to</button></div></div>";

echo $table1; ?>

<script>
function sendmsg(senduser){
  alert(senduser); 
}
</script>

answered Mar 5, 2015 at 12:01

I'm Geeker

4,6575 gold badges25 silver badges42 bronze badges

Collectives™ on Stack Overflow

a javascript fuction doesn't execute when i echo that in php code

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related