getting error echoing javascript in PHP

Question

Im getting an error that there is a syntax problem on the line where selection = ui.item.addClass etc.. , but I can't figure out what it is. I think I have escaped all the right quotes but I'm not sure. note: the first two variables are meant to contain empty single quotes.

<?php      
echo    "<script>";

echo    "$(function(){";


echo  "var selection = \' \'; ";

echo  "var selectClass = \' \'; ";

echo  " $(\".menu\").menu({ ";

echo  " select: function (event, ui) { "
echo   " $(\'.selected\', this).removeClass(\'selected\'); ";
echo     "  selection = ui.item.addClass(\'selected\').children(\'a\').attr(\'name\');";


echo  " }"; // closes select function

echo  "  }); "; // closes menu
echo  " </script>";
?>

What is the point in the javascript output being echo ;? Why don't you just drop out of your PHP tags then drop back in? — Daryl Gill
– Daryl Gill, Commented Apr 6, 2013 at 22:14
you dont need to escape ' within a " - a plain 'select' would work — karthikr
– karthikr, Commented Apr 6, 2013 at 22:15
better yet why are you mixing javascript with php? separate the logic — David Chase
– David Chase, Commented Apr 6, 2013 at 22:16
This is just something I'm trying out. I'm not sure if I will keep it, but right now mixing javascript and php is the best way I know how to get a javascript variable to another page within all the other code I'm using. — Spilot
– Spilot, Commented Apr 6, 2013 at 22:41

Svetoslav · Accepted Answer · 2013-04-06 22:23:20Z

6

First I shall simplify your code:

<?php      
echo  <<<'SCRIPT'
<script>
$(function(){
    var selection = ' ';
    var selectClass = ' ';
    $(".menu").menu({
        select: function (event, ui) {
            $('.selected', this).removeClass('selected');
            selection = ui.item.addClass('selected').children('a').attr('name');
        } // closes select function
    }); // closes menu
}); // close function()
</script>
SCRIPT;
?>

You will find this "magically" fixes your problem because now you don't have the missing semicolon ;)

edited Apr 6, 2013 at 22:23

Svetoslav

4,6862 gold badges30 silver badges43 bronze badges

answered Apr 6, 2013 at 22:16

Niet the Dark Absol

326k86 gold badges480 silver badges604 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Svetoslav · Accepted Answer · 2013-04-06 22:25:50Z

4

Personally. I'd drop out of the tags for my Javascript.. When I have finished typing, I see no harm in re-opening PHP tags to continue..

 //Other code here 
?>
<script>
$(function(){


var selection = ' ';

var selectClass = ' ';

$(".menu").menu({

select: function (event, ui) { 
$('.selected', this).removeClass('selected');
selection = ui.item.addClass('selected').children('a').attr('name');


}// closes select function

});// closes menu
});// closes function()
</script>

<?php 
// Continue here 

?>

edited Apr 6, 2013 at 22:25

Svetoslav

4,6862 gold badges30 silver badges43 bronze badges

answered Apr 6, 2013 at 22:17

Daryl Gill

5,52511 gold badges41 silver badges71 bronze badges

Comments

hjpotter92 · Accepted Answer · 2013-04-06 22:15:53Z

1

You are missing a semi-colon in line #14

echo  " select: function (event, ui) { ";
echo   " $(\'.selected\', this).removeClass(\'selected\'); ";

Fixing which gives this: http://eval.in/15236

<script>$(function(){var selection = \' \'; var selectClass = \' \';  $(".menu").menu({  select: function (event, ui) {  $(\'.selected\', this).removeClass(\'selected\');   selection = ui.item.addClass(\'selected\').children(\'a\').attr(\'name\'); }  });  </script>

answered Apr 6, 2013 at 22:15

hjpotter92

81.1k36 gold badges148 silver badges188 bronze badges

Comments

Guzzilar · Accepted Answer · 2013-04-06 22:18:42Z

0

in last line add this

echo  "  }); "; // closes menu
// --- add this
echo " });";
// -----
echo  " </script>";

try it :D

answered Apr 6, 2013 at 22:18

Guzzilar

32 bronze badges

Collectives™ on Stack Overflow

getting error echoing javascript in PHP

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related